Use new Kustomise env var syntax.

[davinchia]

What

As title.

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• Secrets are annotated with airbyte_secret in the connector's spec
• Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
• Unit & integration tests added as appropriate (and are passing)
  • Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• /test connector=connectors/<name> command as documented here is passing.
  • Community members can skip this, Airbyters will run this for you.
• Code reviews completed
• Documentation updated
  • README.md
  • docs/SUMMARY.md if it's a new connector
  • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
  • Changelog in the appropriate page in docs/integrations/.... See changelog example
  • docs/integrations/README.md contains a reference to the new connector
  • Build status added to build page
• Build is successful
• Connector version bumped like described here
• New Connector version released on Dockerhub by running the /publish command described here
• No major blockers
• PR merged into master branch
• Follow up tickets have been created
• Associated tickets have been closed & stakeholders notified

Connector Generator checklist

• Issue acceptance criteria met
• PR name follows PR naming conventions
• If adding a new generator, add it to the list of scaffold modules being tested
• The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
• Documentation which references the generator is updated as needed.

[davinchia]

This is blocked by helm/kind-action#45.

[jrhizor]

This is precisely why we reverted the env change that was just redone in #4966

env is much more broadly supported compared to envs. I think in the most recent version shows a warning but it will just fail on other versions like it does here in CI.

[davinchia]

oops I didn't know that, @jrhizor should we revert it all then?

slight preference for moving to the later version but also okay if we don't do that.

[jrhizor]

#4966 (comment)

It looks like we will run into problems on either side. I did have trouble with packaged versions of kubectl, though (in kind/minikube/docker for desktop/etc).

Maybe we should just document the old approach in a comment below the new approach?

[davinchia]

yeah this is going to run into problems for kubectl versions < 1.21.

Documenting makes sense. I'll wait till the Kind folks publish their update and then follow up here.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[davinchia]

We are moving to Helm.