Change content type for openmetrics expositions to prometheus text format #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat The implementation is actually far from adhering to the OpenMetrics standard, which causes problems for scrapers that rely on the content-type for deciding how to parse the metrics exposition.
|
It would be better to fix the bugs you're pointing out rather than change the content type. Can you go into more detail or potentially look into fixing those issues in this PR instead? Ideally we'd support the full openmetrics standard. I think NaN values is something we've seen as well internally at Starburst. |
|
I'm afraid I most definitely don't have the bandwidth to work on making the exposition OpenMetrics-compliant, but I'm also not sure there's a clear benefit to doing so; the Prometheus exposition format is still more widespread and widely supported than OpenMetrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The format produced by this implementation is actually not adhering to the OpenMetrics standard, which causes problems for scrapers that rely on the content-type for deciding how to parse the metrics exposition. The official Prometheus Python client's parser will raise errors when trying to parse metrics coming out of this implementation. For example,
NaNvalues are not allowed in histograms and summaries, and counters must include a_totalsuffix for the actual sample value.The Prometheus text exposition format is much less strict and is therefore a better match for the way the current implementation exposes metrics. Thus, this PR suggests modifying the content type to match the one recommended for that format.