Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for probabilistic sampling in Tracing #1148

Merged
merged 2 commits into from
May 21, 2024
Merged

Add support for probabilistic sampling in Tracing #1148

merged 2 commits into from
May 21, 2024

Conversation

vinay-kosaraju
Copy link
Contributor

No description provided.

@vinay-kosaraju vinay-kosaraju changed the title Add support for probabilistic sampling Add support for probabilistic sampling in Tracing Apr 27, 2024
@mattstep mattstep requested a review from electrum April 28, 2024 05:13
@vinay-kosaraju vinay-kosaraju force-pushed the master branch 2 times, most recently from a75ca11 to 4b70a1e Compare May 7, 2024 23:26
electrum
electrum approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one more thing, I should have mentioned it: can you do the rename of OpenTelemetryConfig in a separate commit? That will make the commits easier to read. This should be easy since the changes are in separate files.

@electrum electrum merged commit 1996e04 into airlift:master May 21, 2024
3 checks passed
@electrum
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erichwang erichwang erichwang left review comments

@electrum electrum electrum approved these changes

@mattstep mattstep mattstep approved these changes

@elonazoulay elonazoulay elonazoulay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vinay-kosaraju @electrum @mattstep @erichwang @elonazoulay