Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP/2+TLS on client and server sides #1156

Closed
wants to merge 16 commits into from
Closed

Add support for HTTP/2+TLS on client and server sides #1156

wants to merge 16 commits into from

Conversation

wendigo
Copy link
Collaborator

@wendigo wendigo commented May 6, 2024 •
edited

@wendigo wendigo mentioned this pull request May 6, 2024
Open
@wendigo
Copy link
Collaborator Author

wendigo commented May 6, 2024

cc @electrum

@wendigo
Copy link
Collaborator Author

wendigo commented May 6, 2024

With the DynamicTransport for the client we should get rid of the enableHttp2 flag and enable HTTP/2 by default on the client side (and maybe add a toggle for HTTP/2+TLS on the server side). WDYT @electrum ?

@mosabua
Copy link

mosabua commented May 6, 2024 •
edited

Fyi @sajjoseph

@mosabua
Copy link

mosabua commented May 6, 2024

Replaces #1146

@mosabua mosabua mentioned this pull request May 6, 2024
Closed
electrum
electrum approved these changes May 6, 2024
View reviewed changes
http-client/src/main/java/io/airlift/http/client/jetty/JettyHttpClient.java Outdated Show resolved Hide resolved
http-client/src/main/java/io/airlift/http/client/Request.java Show resolved Hide resolved
http-client/src/main/java/io/airlift/http/client/Request.java Outdated Show resolved Hide resolved
http-client/src/main/java/io/airlift/http/client/Request.java Outdated Show resolved Hide resolved
http-client/src/main/java/io/airlift/http/client/HttpVersion.java Outdated Show resolved Hide resolved
http-server/src/main/java/io/airlift/http/server/testing/TestingHttpServer.java Outdated Show resolved Hide resolved
http-server/src/test/java/io/airlift/http/server/testing/TestTestingHttps2Server.java Outdated Show resolved Hide resolved
http-server/src/test/java/io/airlift/http/server/testing/TestTestingHttps2Server.java Outdated Show resolved Hide resolved
http-server/src/test/java/io/airlift/http/server/testing/TestTestingHttps2Server.java Outdated Show resolved Hide resolved
http-client/src/test/java/io/airlift/http/client/jetty/AbstractHttpsClientTest.java
assertEquals(version, testedHttpVersion());
}

// TLS connections seem to have some conditions that do not respect timeouts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's file issues for these. Hopefully easy for them since we have a reproduction.

@electrum electrum requested a review from dain May 6, 2024 20:52
@electrum
Copy link
Member

electrum commented May 6, 2024

@wendigo I think that makes sense. We added HTTP/2 support originally before Java supported ALPN and it was intended for use with "h2c" (unencrypted) so the flag was needed as negotiation wasn't possible. Though we should default it to enabled first and leave the config around as a failsafe.

@wendigo wendigo force-pushed the serafin/jetty-http-2 branch 4 times, most recently from 1979714 to 442ec74 Compare May 25, 2024 16:50
@wendigo wendigo requested a review from electrum May 25, 2024 16:51
@wendigo
Copy link
Collaborator Author

wendigo commented May 25, 2024

@electrum ptal

@wendigo wendigo force-pushed the serafin/jetty-http-2 branch 4 times, most recently from cf5e0d3 to 6f01099 Compare May 25, 2024 19:02
@wendigo
Copy link
Collaborator Author

wendigo commented May 25, 2024

There is H2C client failure that seems to be caused by Jetty client code. Reported back.

@wendigo wendigo force-pushed the serafin/jetty-http-2 branch 6 times, most recently from 6fcac23 to 8bc914d Compare May 25, 2024 20:42
@wendigo wendigo closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dain dain Awaiting requested review from dain

@electrum electrum Awaiting requested review from electrum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wendigo @mosabua @electrum