Reimplement request/response timing - improves accuracy and correctness #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know that this PR is pretty big but it drops a lot of unnecessary code and aligns the code for better readability. It's best to review it with the checked out code to see how it looks like after changes. |
wendigo
force-pushed
the
serafin/revamp-timings
branch
2 times, most recently
from
44a4cad
to
7a2a4d1
Compare
|
Alternative to #1160 |
wendigo
force-pushed
the
serafin/revamp-timings
branch
3 times, most recently
from
da5bd54
to
c59d3fe
Compare
|
@electrum PTAL. Currenty these timings are broken for async responses. |
- Increase metrics precision to nanoseconds using monotonically increasing time source - Drop TimingFilter and capture metrics on the Jetty level alone - Validate timings invariants for correctness - Fix metrics capture when async servlet API is used
wendigo
force-pushed
the
serafin/revamp-timings
branch
from
c59d3fe
to
29d3552
Compare
wendigo
changed the title
|
@electrum PTAL. Right now this doesn't work for async servlet at all. I've tested it thoroughly and added invariants that check that corresponding processing stages happen monotonically. In HTTP/2 where requests are really fast (us/ms) this matters for accuracy: 
|
electrum
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: