Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change statusCode for PrintHelpMessage to 0 #425

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Change statusCode for PrintHelpMessage to 0 #425

merged 1 commit into from
Jul 11, 2023

Conversation

ajalt
Copy link
Owner

@ajalt ajalt commented Jul 11, 2023

No description provided.

@ajalt ajalt enabled auto-merge (squash) July 11, 2023 17:48
@ajalt ajalt mentioned this pull request Jul 11, 2023
Merged
@ajalt ajalt merged commit 8cf21ad into master Jul 11, 2023
3 checks passed
@ajalt ajalt deleted the help-status branch July 11, 2023 17:54
@sschuberth
Copy link
Contributor

Thanks for this! Just curious: Was this an indented change for version 4 that turned out not to be a good idea, or an unintended change?

@sschuberth sschuberth mentioned this pull request Jul 11, 2023
Closed
@ajalt
Copy link
Owner Author

ajalt commented Jul 11, 2023 •
edited

Unintended. It was a result of adding the statusCode to the root ClitkError, but not updating the super constructor calls of the print exceptions.

I added tests so that this doesn't regress again in the future.

@sschuberth sschuberth mentioned this pull request Jul 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajalt @sschuberth