Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8.3 + Kotlin 1.9.10 #448

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Gradle 8.3 + Kotlin 1.9.10 #448

merged 3 commits into from
Oct 2, 2023

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Aug 31, 2023

We can kick these things by enabling @renovate-bot.

@Goooler Goooler changed the title Gradle 8.3 + Kotlin 1.9 Gradle 8.3 + Kotlin 1.9.10 Aug 31, 2023
@ajalt
Copy link
Owner

ajalt commented Aug 31, 2023

There are a lot of unrelated changes here. Please trim this down to just the version bumps.

build.gradle.kts Outdated
Comment on lines 8 to 10
kotlin("multiplatform").version(libs.versions.kotlin).apply(false)
alias(libs.plugins.dokka).apply(false)
alias(libs.plugins.publish).apply(false)
alias(libs.plugins.kotlin.multiplatform) apply false
alias(libs.plugins.dokka) apply false
alias(libs.plugins.publish) apply false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary, let Renovate honor the Kotlin version.

@Goooler
Copy link
Contributor Author

Goooler commented Sep 1, 2023

Maybe we can rebase these commits?

@ajalt
Copy link
Owner

ajalt commented Sep 1, 2023

I'm not interested in adding renovate or any other bots. Please remove it from the PR and keep the changes limited to just the kotlin and gradle version bumps.

@ajalt ajalt enabled auto-merge (squash) October 2, 2023 18:15
@ajalt ajalt merged commit 6f1ae0f into ajalt:master Oct 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants