Improve support for recursive lazy paraemeters #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow lazy options and arguments to reference parameters from groups, and allow unlimited recursion.
The way we support parameters referencing other parameters is by collecting any parameters that
failed to finalize and finalizing them again after all other parameters have succeeded.
Prior to this PR, we finalized options, groups, and arguments in separate passes. These passes were
interleaved and carefully ordered to work correctly.
This PR does away with the manual pass ordering and instead finalizes all parameters repeatedly,
iterating until a fixed point is reached.
Fixes #473