-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add gutter controls to keyboard accessibility mode #5146
Merged
Merged
Changes from 56 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
097b633
add gutter keyboard handler
akoreman e22f066
Merge branch 'ajaxorg:master' into keyboard_gutter
akoreman 86c34de
fixes
akoreman 53b752f
Merge branch 'keyboard_gutter' of https://github.com/akoreman/ace int…
akoreman de509b6
improve handling number of edge-cases
akoreman ed20e41
add scrolling if cursor outside viewport
akoreman c1aa747
add annotation control
akoreman 6fa7132
refactor gutter tooltip
akoreman e0b78ad
correctly set annotation tooltip position
akoreman d6a9555
refactoring
akoreman 277b3bd
more refactoring
akoreman 8aaf737
add/remove semi-colons
akoreman 7d0ad22
refactor to pass eslint
akoreman bca6730
fix edge case
akoreman d48b49d
refactor
akoreman 0f89839
fix edge case
akoreman f484162
add support folded annotation
akoreman 14d4f7c
read active row on focus
akoreman 06a53f0
refactor
akoreman 7d93299
aria label unfold line
akoreman e490059
hande more edge cases
akoreman 1fec596
style fix
akoreman 42d5484
add end row unfold aria label
akoreman 393b3de
refactor
akoreman 329b118
fix typo
akoreman 5b5e6b4
add basic test
akoreman b41bc04
add KeyboardEvent to eslint globals
akoreman e5b9e38
tweak fold test
akoreman 6364be5
fix comma dangle
akoreman e39e58d
Merge branch 'ajaxorg:master' into keyboard_gutter
akoreman df94c8b
add multiple annotation test
akoreman 85b7c27
add multi fold test
akoreman 8f5bf05
add tests
akoreman 17e1d84
extend multi icon test
akoreman 814ae0b
refactoring + style
akoreman 74d26b4
Merge branch 'ajaxorg:master' into keyboard_gutter
akoreman fab6d43
refactor
akoreman 17825ed
renaming
akoreman 6fcfd17
add focus outline SVG icons
akoreman 031ee05
fix css
akoreman 9c9621e
fix failing test
akoreman 7a0d35f
Merge branch 'ajaxorg:master' into keyboard_gutter
akoreman d3c73de
fix edge case
akoreman 8b2850a
refactor
akoreman b3ef448
simplify logic
akoreman f3e07d7
fix test
akoreman e503b12
refactor
akoreman 05bd7a9
cleanup
akoreman c779796
more cleanup
akoreman 7610d62
fix test
akoreman 94b5948
Merge branch 'ajaxorg:master' into keyboard_gutter
akoreman a50f2b1
hide tooltip on gutter blur
akoreman 2e5917c
cleanup
akoreman 1c9606f
Merge branch 'ajaxorg:master' into keyboard_gutter
akoreman abfa429
improve finding active row
akoreman 1cef515
only move to fully visible icons
akoreman 0b64a95
change how a11y props are removed
akoreman 97686b0
fix scroll bug
akoreman 25dd3c3
improve behaviour end of doc
akoreman 029f9e4
cleanup
akoreman fdb1355
blur keyboard gutter on mouse wheel
akoreman 00dddb0
fix typo
akoreman File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a best approach for removing the aria attributes, is it set them to empty value or remove them completely. I guess I followed a different approach and asking to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there are differences between how assistive tech interpret it but it probably makes more sense to just remove the attributes. I'll update the PR.