Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for asynchronous compilation #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rayvincent2
Copy link

Adds Asynchronous schema compilation support.

To reduce the complexity of the implementation, the compile command will only attempt asynchronous complication if only one schema is provided. When multiple schemas are provided to compile, asynchronous complication is disabled.

validate and test will always use asynchronous compilation by default. Of course, the application will not attempt to asynchronously request any remote schemas if they're provided by the -r option.

@epoberezkin
Copy link
Member

epoberezkin commented Mar 6, 2021

Interesting... If this is added, it should be definitely with additional option, so it's opt-in, otherwise it is a breaking change and I do not think I agree with it - the requirement to resolve URI via network requests is not very common, and in any case non-standard.

So the option to enable it could be --load-schema, and then it would add option loadSchema that gets schemas over HTTP(S) (or any other supported protocol in the URI).

It should work regardless how many schemas are passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants