Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): move ajv from devDepenencies to dependencies #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rublea
Copy link

@rublea rublea commented May 10, 2021

No description provided.

@rublea rublea changed the title Move ajv from devDepenencies to dependencies chore(dep): move ajv from devDepenencies to dependencies May 10, 2021
@rublea rublea changed the title chore(dep): move ajv from devDepenencies to dependencies chore(deps): move ajv from devDepenencies to dependencies May 10, 2021
@rublea
Copy link
Author

rublea commented May 10, 2021

@epoberezkin I believe ajv should be added as a dependency to this project. Can you approve the workflow ?

@rublea rublea changed the title chore(deps): move ajv from devDepenencies to dependencies dev(deps): move ajv from devDepenencies to dependencies May 10, 2021
@rublea rublea changed the title dev(deps): move ajv from devDepenencies to dependencies fix(deps): move ajv from devDepenencies to dependencies May 10, 2021
@rublea
Copy link
Author

rublea commented May 12, 2021

@epoberezkin Would you have time to take a look on this PR, it's a small one ?

@solaris007
Copy link

can this be merged? it fixes this error:

Error: Cannot find module 'ajv/dist/compile/codegen'
Require stack:
- /some/project/node_modules/ajv-errors/dist/index.js

@mustafamilyas
Copy link

mustafamilyas commented Nov 25, 2021

I think this PR is really important, we have an issue with the submodule which depends on ajv-errors and on the main module, it points to the outdated version of ajv because it is already installed by other modules which install the outdated version. Our current solution is to install it directly on the main module and then remove it to make sure ajv on node_modules is compatible with ajv-errors but we think it is not scalable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants