Clean up NettyClientUtils#createNettySslContext #1649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inserting a JDK
javax.net.ssl.SSLContext
into Netty originated in commitakka-grpc/runtime/src/main/scala/akka/grpc/internal/NettyClientUtils.scala
Lines 59 to 82 in aa05239
in PR #266
It was removed in PR #964
to address Issue #946
It was returned in PR #979
to address Issue #978
Original comment was
This commit addresses the original
FIXME
comment, and avoids usingdeprecated constructors on
io.grpc.netty.shaded.io.netty.handler.ssl.JdkSslContext