=act Extract AtomicCancellable in Scheduler. #31915
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
force-pushed
the
scheduler-op
branch
2 times, most recently
from
233dad1
to
0e66f16
Compare
patriknw
reviewed
Aug 15, 2023
| scheduleOnce( | ||
| initialDelay, | ||
| new Runnable { | ||
| override def run(): Unit = { | ||
| try { | ||
| runnable.run() | ||
| if (self.get != null) | ||
| if (get != null) |
There was a problem hiding this comment.
in the other place it is
if (self.get() != null)
There was a problem hiding this comment.
why is self => used there but not here?
There was a problem hiding this comment.
Because I need to access the AtomicReference there but not the outer AtomicLong, and here we can access it directly.
He-Pin
commented
Aug 15, 2023
| schedule( | ||
| executor, | ||
| new AtomicLong(clock() + initialDelay.toNanos) with Runnable { | ||
| override def run(): Unit = { | ||
| try { | ||
| runnable.run() | ||
| val driftNanos = clock() - getAndAdd(delay.toNanos) | ||
| if (self.get != null) | ||
| if (self.get() != null) |
There was a problem hiding this comment.
self refs to the AtomicReference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a little refractory when reading the code