remove info log showing Slf4jLogger started to avoid slf4j warning at the top #31395 #32039
Conversation
dongxuwang
changed the title
|
Hi @patriknw , I updated the pr, do you think we also need to un-extend Slf4jLogger with SLF4JLogging? |
| @@ -104,7 +104,6 @@ class Slf4jLogger extends Actor with SLF4JLogging with RequiresMessageQueue[Logg | |||
| } | |||
|
|
|||
| case InitializeLogger(_) => | |||
| log.info("Slf4jLogger started") | |||
There was a problem hiding this comment.
I think this should anyway touch the log because that is a lazy val and if we don't touch it we haven't really started the intiialization yet, and next real log message will do that.
There was a problem hiding this comment.
How about let Slf4jLogger NOT to extend SLF4JLogging
There was a problem hiding this comment.
That would be fine, but it would still have to create the logger at some point.
Well, there is a problem with compatibility if removing SLF4JLogging, because Slf4jLogger is public api and not final. Someone may have extended it and expect that log.
There was a problem hiding this comment.
yes, that's also another point.
References #31395
This would significantly enlarge the change to get slf4j warning silent