New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-str Remove deprecated methods in GraphStage since 2.6.0 #32059
base: main
Are you sure you want to change the base?
Conversation
5aef59c
to
06b8733
Compare
onDownstreamFinish()
in GraphStage.06b8733
to
fc45c64
Compare
fc45c64
to
ff27e09
Compare
@throws(classOf[Exception]) | ||
@deprecatedOverriding("Override `def onDownstreamFinish(cause: Throwable)`, instead.", since = "2.6.0") // warns when overriding | ||
@deprecated("Call onDownstreamFinish with a cancellation cause.", since = "2.6.0") // warns when calling | ||
def onDownstreamFinish(): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if this has been fully migrated everywhere in Akka libraries? We might want to keep this for some longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only stream contrib among the repo mains as far as I can see, but still might be best to keep it around for some more time.
TimerScheduler and Scheduler have the same thing here, you may want to remove it too. akka/akka-actor-typed/src/main/scala/akka/actor/typed/scaladsl/TimerScheduler.scala Lines 213 to 220 in 85236f8
akka/akka-actor/src/main/scala/akka/actor/Scheduler.scala Lines 354 to 362 in 85236f8
|
Remove deprecated methods in GraphStage since 2.6.0