bump: Scala 2.13.8 (drop 2.12), Akka 2.6.18 #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
788a63d
to
274375e
Compare
|
The ScalaDoc error in the Spring web module is scala/scala#9806 and will be fixed in Scala 2.13.8 |
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
f4c6b90
to
c992eef
Compare
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
8808b23
to
4668a40
Compare
Closed
ennru
force-pushed
the
ennru-drop-scala-2.12
branch
from
93b4cb9
to
28aed7e
Compare
ennru
changed the title
|
Scala 2.13.8 is on Maven Central already. |
ennru
changed the title
Closed
johanandren
approved these changes
Jan 17, 2022
| val codecRegistry = | ||
| fromRegistries(fromProviders(classOf[Number], classOf[DomainObject]), DEFAULT_CODEC_REGISTRY): @nowarn( | ||
| "msg=match may not be exhaustive" | ||
| ) |
There was a problem hiding this comment.
No pattern matching going on here?
There was a problem hiding this comment.
Very hidden indeed:
[warn] /Users/enno/dev/alpakka/mongodb/src/test/scala/docs/scaladsl/MongoSinkSpec.scala:40:41: match may not be exhaustive.
[warn] It would fail on the following input: (x: String forSome x not in "Number")
[warn] fromRegistries(fromProviders(classOf[Number], classOf[DomainObject]), DEFAULT_CODEC_REGISTRY)
[warn] ^
[warn] /Users/enno/dev/alpakka/mongodb/src/test/scala/docs/scaladsl/MongoSinkSpec.scala:40:58: match may not be exhaustive.
[warn] It would fail on the following input: (x: String forSome x not in "DomainObject")
[warn] fromRegistries(fromProviders(classOf[Number], classOf[DomainObject]), DEFAULT_CODEC_REGISTRY)
| @@ -64,8 +62,7 @@ private[impl] class AlpakkaResultMapperHelper { | |||
| val columnName: String = column.name() | |||
| val fieldType: Class[_] = field.getType() | |||
|
|
|||
| @silent("deprecated") | |||
| val isAccessible = field.isAccessible() | |||
| val isAccessible = field.isAccessible() // deprecated in JDK 11+ | |||
There was a problem hiding this comment.
Hmm, but @nowarn not needed?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for a major release of Alpakka to only publish Scala 2.13 artefacts.
@nowarninstead of Silencer plugin