Fix: http-kafka will fetch messages that have been deleted by a reten… #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
May 20, 2024
...va/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaCacheServerFetchFactory.java
Outdated
Show resolved
Hide resolved
| @@ -126,23 +126,26 @@ public void init( | |||
| this.latestOffset = latestOffset; | |||
|
|
|||
| assert !segmentNode.sentinel(); | |||
| KafkaCacheSegment newSegment = null; | |||
| while (newSegment == null) | |||
| if (segmentNode.segment() != null) | |||
There was a problem hiding this comment.
if the assert above is true, such that segmentNode is not the sentinel, then is it still possible for segmentNode.segment() != null to be false?
There was a problem hiding this comment.
that's a possible case, as before we call cursor.init() method, mentioned check is done. Thus making segmentNode.segment() == null possible even after asserting !segmentNode.sentinel()
if (segmentNode.sentinel())
{
segmentNode = segmentNode.next();
}
...va/io/aklivity/zilla/runtime/binding/kafka/internal/stream/KafkaCacheServerFetchFactory.java
Outdated
Show resolved
Hide resolved
jfallows
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion policy
Fixes #897