-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use container image repo client from go-containerregistry #2018
Conversation
✅ Deploy Preview for docs-kargo-akuity-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d674953
to
e0f434c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2018 +/- ##
==========================================
- Coverage 45.81% 45.63% -0.18%
==========================================
Files 235 234 -1
Lines 16192 16001 -191
==========================================
- Hits 7418 7302 -116
+ Misses 8413 8342 -71
+ Partials 361 357 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
e0f434c
to
5af5cf0
Compare
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com> Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs with a negative LOC are always great, if they also deal with deprecated dependencies it's even better.
Three birds, one stone IMHO. 💯
Fixes #1488
This is a giant step toward solving #1885 since go-containerregistry supports quite a variety of authn options, including the ability to emulate ACR, ECR, and GCR Docker credentials helpers. Those new authn methods are not included in this PR. Those will come in a follow-up.
Note that I prefer we merge #1984 before this since I know there will be merge conflicts between the two PRs and I volunteer as tribute.All set.