Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use container image repo client from go-containerregistry #2018

Merged
merged 4 commits into from
May 16, 2024

Conversation

krancour
Copy link
Member

@krancour krancour commented May 15, 2024

Fixes #1488

This is a giant step toward solving #1885 since go-containerregistry supports quite a variety of authn options, including the ability to emulate ACR, ECR, and GCR Docker credentials helpers. Those new authn methods are not included in this PR. Those will come in a follow-up.

Note that I prefer we merge #1984 before this since I know there will be merge conflicts between the two PRs and I volunteer as tribute. All set.

@krancour krancour added this to the v0.7.0 milestone May 15, 2024
@krancour krancour self-assigned this May 15, 2024
@krancour krancour requested a review from a team as a code owner May 15, 2024 20:57
Copy link

netlify bot commented May 15, 2024

Deploy Preview for docs-kargo-akuity-io ready!

Name Link
🔨 Latest commit 926ca71
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-akuity-io/deploys/664684a514eca50008cc636d
😎 Deploy Preview https://deploy-preview-2018.kargo.akuity.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

internal/image/creds.go Outdated Show resolved Hide resolved
@krancour krancour force-pushed the krancour/go-containerregistry branch from d674953 to e0f434c Compare May 16, 2024 19:10
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 65.41353% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 45.63%. Comparing base (828acc0) to head (926ca71).
Report is 1 commits behind head on main.

Files Patch % Lines
internal/image/repository_client.go 77.77% 21 Missing and 3 partials ⚠️
internal/image/digest_selector.go 0.00% 13 Missing ⚠️
internal/image/newest_build_selector.go 0.00% 5 Missing ⚠️
internal/image/lexical_selector.go 0.00% 2 Missing ⚠️
internal/image/semver_selector.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
- Coverage   45.81%   45.63%   -0.18%     
==========================================
  Files         235      234       -1     
  Lines       16192    16001     -191     
==========================================
- Hits         7418     7302     -116     
+ Misses       8413     8342      -71     
+ Partials      361      357       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>

Co-authored-by: Hidde Beydals <hiddeco@users.noreply.github.com>
Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs with a negative LOC are always great, if they also deal with deprecated dependencies it's even better.

Three birds, one stone IMHO. 💯

@krancour krancour added this pull request to the merge queue May 16, 2024
Merged via the queue into akuity:main with commit ae35631 May 16, 2024
17 checks passed
@krancour krancour deleted the krancour/go-containerregistry branch May 16, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distribution/distribution v3 deprecates packages we use
2 participants