Update Oracle JDK download URL calculation #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolai-laevskii
force-pushed
the
update-oracle-jdk-url-calculation
branch
from
f14f691
to
6f8a584
Compare
dsame
approved these changes
Jun 8, 2023
marko-zivic-93
approved these changes
Jun 9, 2023
marko-zivic-93
approved these changes
Jun 9, 2023
nikolai-laevskii
force-pushed
the
update-oracle-jdk-url-calculation
branch
from
2097db9
to
ebe05e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates how Oracle JDK download URL is determined.
Previously it would pick either "archive" or "latest" download links depending on whether user specified just major version (it would select "latest") or major.minor.(patch) as well (it would select "archive"). It doesn't seem like a correct logic because it's just the version format, it shouldn't determine whether it should be taken from the archive or from latest. Moreover, links for latest versions are invalidated often which causes tests to fail and may potentially break workflows of some people.
I propose just picking every version from the "archive" as even latest versions added there immediately and archive links don't seem to change that often.
Related issue:
No particular issue
Check list: