Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'export * from' with enableLegacyTypeScriptModuleInterop #236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aleclarson
Copy link
Contributor

No description provided.

@alangpierce
Copy link
Owner

Thanks! Can you add a test? I think typescript-test.ts is the best place.

@aleclarson
Copy link
Contributor Author

There are no tests for the enableLegacyTypeScriptModuleInterop option yet, so I didn't bother. I'm not knowledgable on the potential edge cases. I just noticed this while working on another upcoming pull request. Sorry!

@alangpierce
Copy link
Owner

I think you should be able to either add a param to assertTypeScriptResult or make a similar assertion function. Just a simple case should be fine for this sort of thing, but I would prefer tests for every change, and actually find it to be a really nice aspect of working on Sucrase.

And yeah, I guess I was a bit lazy when adding enableLegacyTypeScriptModuleInterop and updated tests for the new output but didn't add tests for both cases. See https://github.com/alangpierce/sucrase/pull/202/files#diff-763ef3d30486c4fcadd81744662399ff for the old tests.

Base automatically changed from master to main January 31, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants