Add source map debugging to website #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward #541, prep work to help make #759 (and any future source map work) more manually testable. This PR splits out token information into a new collapased-by-default debug section, then adds source map info to that section. The source map toggle does three things: * Show the actual mappings from the source map by line/column index. * Show the JSON value of the source map. * Extend the normal code output to include an inline source map with the full original source embedded, then link to the very helpful tool https://evanw.github.io/source-map-visualization/ , which accepts pasting the output code.
Codecov Report
@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 55 55
Lines 5955 5955
Branches 1415 1415
=======================================
Hits 5260 5260
Misses 430 430
Partials 265 265 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 408.4 thousand lines per second Measured change: 0.33% slower (1.79% slower to 2.06% faster) |
alangpierce
added a commit
to forivall/sucrase
that referenced
this pull request
Apr 9, 2023
* Get rid of simple source map mode. For now, the detailed source maps will be the only mode. Also inline `computeDetailedSourceMap` now that it's the only case. * Remove `WRITE_SOURCE_MAPS` in test and related details. In alangpierce#793 I added source map info to the demo website, which is a nicer system for manually verifying correctness. * Update test code to assert the full source map and a JSON representation of the mappings. * Add integration test for Jest inline snapshots. * Change lint config to ignore unused rest siblings. * Add bounds checks and change empty `for` loops to `while` (just a style preference). * Add comments in a few more places. * Remove unnecessary special case when handling hashbang lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #541, prep work to help make #759 (and any future source map work) more manually testable.
This PR splits out token information into a new collapased-by-default debug section, then adds source map info to that section. The source map toggle does three things: