Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly elide type-only re-export statements when targeting ESM #806

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Properly elide type-only re-export statements when targeting ESM #806

merged 1 commit into from
Jul 11, 2023

Conversation

alangpierce
Copy link
Owner

Fixes #803
Fixes #805

When handling TypeScript, fix two issues involving statements starting with export {:

  • Re-exports need to remove the module import if all exported names are explicitly elided.
  • Re-exports should NOT do the implicit export elision that's needed for normal multi-exports.

@alangpierce
Properly elide type-only re-export statements when targeting ESM
8645bc4 
Fixes #803
Fixes #805

When handling TypeScript, fix two issues involving statements starting with
`export {`:
* Re-exports need to remove the module import if all exported names are
  explicitly elided.
* Re-exports should NOT do the implicit export elision that's needed for normal
  multi-exports.
@github-actions
Copy link

Benchmark results

Before this PR: 388.6 thousand lines per second
After this PR: 388.8 thousand lines per second

Measured change: 0.05% faster (0.5% slower to 0.19% faster)
Summary: Likely no significant difference

@alangpierce alangpierce merged commit 6854479 into main Jul 11, 2023
6 checks passed
@alangpierce alangpierce deleted the fix-type-only-re-export-elision branch July 11, 2023 06:36
@alangpierce alangpierce mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@alangpierce