Allow specifying options with sucrase/register and related tools #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #792 This PR adds a new environment variable SUCRASE_OPTIONS that works with the require hook and other tools that are based on the require hook (`sucrase-node` and programmatically registering a hook). Its format is simply a JSON string that is parsed and merged with the usual options. Hopefully this will be rare, especially after a semver-major change to better defaults, but it's important for some cases.
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 56 56
Lines 6082 6082
Branches 1446 1446
=======================================
Hits 5395 5395
Misses 421 421
Partials 266 266 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 402.9 thousand lines per second Measured change: 0.31% slower (0.43% slower to 1.85% faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792
This PR adds a new environment variable SUCRASE_OPTIONS that works with the require hook and other tools that are based on the require hook (
sucrase-nodeand programmatically registering a hook). Its format is simply a JSON string that is parsed and merged with the usual options. Hopefully this will be rare, especially after a semver-major change to better defaults, but it's important for some cases.