Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building on Windows (using Git Bash) #826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Expand Up @@ -44,7 +44,8 @@ more concrete suggestions.

## Getting started

Sucrase uses `yarn` for everything.
Sucrase uses `yarn` for everything. On Windows, either use `Git Bash` or
build from Windows Subsystem for Linux (WSL).

```bash
git clone git@github.com:alangpierce/sucrase.git
Expand Down
1 change: 1 addition & 0 deletions prettier.config.js
Expand Up @@ -3,4 +3,5 @@ module.exports = {
parser: "typescript",
printWidth: 100,
trailingComma: "all",
endOfLine: "auto"
};
2 changes: 1 addition & 1 deletion script/run.ts
Expand Up @@ -11,7 +11,7 @@ import {spawn} from "child_process";
export default function run(command: string): Promise<void> {
console.log(`> ${command}`);
return new Promise((resolve, reject) => {
const childProcess = spawn("/bin/bash", ["-c", command], {stdio: "inherit"});
const childProcess = spawn("bash", ["-c", command], {stdio: "inherit"});
childProcess.on("close", (code) => {
if (code === 0) {
resolve();
Expand Down