Refactor/chart view #38
Conversation
|
zChanges
force-pushed
the
refactor/chart-view
branch
from
dcdbae4
to
bd9bd3c
Compare
|
Deploy preview for alauda-chart ready! ✅ Preview Built with commit 64b2530. |
zChanges
force-pushed
the
refactor/chart-view
branch
3 times, most recently
from
12d64d9
to
31b683e
Compare
zChanges
force-pushed
the
refactor/chart-view
branch
from
d5abc6d
to
07ec46f
Compare
zChanges
force-pushed
the
refactor/chart-view
branch
from
8ebf801
to
432d287
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (seriesIdx === 1) { | ||
| hRect = null; | ||
|
|
||
| const cx = u.cursor.left * pxRatio; |
Check warning
Code scanning / CodeQL
Implicit operand conversion Warning
| hRect = null; | ||
|
|
||
| const cx = u.cursor.left * pxRatio; | ||
| const cy = u.cursor.top * pxRatio; |
Check warning
Code scanning / CodeQL
Implicit operand conversion Warning
| auto: notAuto, | ||
| range: (_u: uPlot, dataMin: number, dataMax: number) => { | ||
| const minV = min | ||
| ? Math.max(dataMin, min || 0) |
Check warning
Code scanning / CodeQL
Useless conditional Warning
| range: (_u: uPlot, dataMin: number, dataMax: number) => { | ||
| const minV = min | ||
| ? Math.max(dataMin, min || 0) | ||
| : Math.min(dataMin, min || 0); |
Check warning
Code scanning / CodeQL
Useless conditional Warning
| if (!titleFormatter) { | ||
| this.title.text(context.title as string); | ||
| return; | ||
| let tpl: string = title || NOT_AVAILABLE; |
Check warning
Code scanning / CodeQL
Useless conditional Warning
| @@ -6,3 +6,4 @@ lib | |||
| .vercel | |||
| .*cache | |||
| *.tsbuildinfo | |||
| .git | |||
| @@ -6,3 +6,4 @@ LICENSE | |||
| *.sh | |||
| *.tsbuildinfo | |||
| *.lock | |||
| docs | |||
| ] | ||
| } | ||
| ] | ||
| "selector-type-no-unknown": null, |
zChanges
force-pushed
the
refactor/chart-view
branch
from
432d287
to
64b2530
Compare
| @@ -1,7 +1,9 @@ | |||
| { | |||
| "extends": "@1stg/eslint-config/loose", | |||
| "rules": { | |||
| "regexp/strict": "off" | |||
| "regexp/strict": "off", | |||
| # reactive | ||
|
|
||
| > 为了支持配置式 options 更新，图表动态响应更新 | ||
| > reactive 由 on-change 库完成 |
| @@ -65,6 +63,12 @@ | |||
| "optional": true | |||
| } | |||
| }, | |||
| "dependencies": { | |||
| "aphrodite": "^2.4.0", | |||
| "on-change": "^4.0.2", | |||
| "cache": true, | ||
| "detail": true, | ||
| "ignoreAsAssertion": true, | ||
| "ignoreNested": true, | ||
| "ignoreNonNullAssertion": true, | ||
| "showRelativePath": true, | ||
| "strict": true, | ||
| "update": true | ||
| "update": true, | ||
| "ignoreFiles": [ |
|
本地先把 lint 修复完再提交 |
| @@ -65,6 +63,12 @@ | |||
| "optional": true | |||
| } | |||
| }, | |||
| "dependencies": { | |||
| "aphrodite": "^2.4.0", | |||
| "dependencies": { | ||
| "aphrodite": "^2.4.0", | ||
| "on-change": "^4.0.2", | ||
| "placement.js": "^1.0.0-beta.5", |
There was a problem hiding this comment.
这个也过时了，不要用，试试 https://popper.js.org
| "aphrodite": "^2.4.0", | ||
| "on-change": "^4.0.2", | ||
| "placement.js": "^1.0.0-beta.5", | ||
| "uplot": "^1.6.26" |
No description provided.