fix columns names in InvalidResultColumnNames being reported the wrong way round

[andrewjw]

Hi,

The parameters for InvalidResultColumnNames are (expected, got), but they are called as (result_keys, expected_keys). This leads to a slightly confusing error message if you get your query wrong.

Hope this is useful!

Andrew

[albertodonato]

Thanks!

Mind also adding the following change for the existing test?

diff --git a/tests/db_test.py b/tests/db_test.py
index 28f7e32..bdac907 100644
--- a/tests/db_test.py
+++ b/tests/db_test.py
@@ -292,8 +292,12 @@ class TestQuery:
             "query", ["db"], [QueryMetric("metric1", ["label1"])], ""
         )
         query_results = QueryResults(["one", "two"], [(1, 2)])
-        with pytest.raises(InvalidResultColumnNames):
+        with pytest.raises(InvalidResultColumnNames) as error:
             query.results(query_results)
+        assert str(error.value) == (
+            "Wrong column names from query: "
+            "expected (label1, metric1), got (one, two)"
+        )

[albertodonato]

Nevermind, I've pushed a commit with that change (also fixing a failing test).

[albertodonato]

Thanks for reporting and fixing the issue!