Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jsconfig.json files #52

Conversation

MichaelDeBoey
Copy link
Contributor

Closes #51

@MichaelDeBoey
Copy link
Contributor Author

@aleclarson Is there anything I still need to do in order to get this one merged?

@aleclarson
Copy link
Owner

aleclarson commented May 22, 2022

Are you sure the upgrade to tsconfig-paths@4.0.0 is necessary here?

Also, the VSCode docs say this:
image

So you might need to check for jsconfig.json here:

let importerExtRE = /./
if (!opts.loose) {
importerExtRE = config.allowJs
? /\.(vue|svelte|mdx|mjs|[jt]sx?)$/
: /\.tsx?$/

…or else tsconfig-paths needs to set allowJs to true for us.

@MichaelDeBoey
Copy link
Contributor Author

@aleclarson I think this one should be fine now?

@aleclarson
Copy link
Owner

Closing in favor of #57 since I don't have permission to push to your repo

Thanks for the contribution!

@aleclarson aleclarson closed this May 26, 2022
@MichaelDeBoey
Copy link
Contributor Author

@aleclarson Edits by maintainers are enabled though on my branch, so you should be able to push new things 🤔

@aleclarson
Copy link
Owner

aleclarson commented May 26, 2022

Must have been an issue with Codespaces :)

You'll still get credit from my PR

@MichaelDeBoey MichaelDeBoey deleted the support-jsconfig-json-files branch May 27, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jsconfig.json files
2 participants