refactor: nest importedCss and importedAssets under viteMetadata
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ElMassimo
changed the title
importedCss and importedAssts under viteMetadataimportedCss and importedAssets under viteMetadata
Although it's more verbose, it makes it easier to avoid collisions with rollup or other bundlers like WMR.
ElMassimo
force-pushed
the
refactor/vite-metadata
branch
from
f144c15
to
6ae9b3e
Compare
aleclarson
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested
importedCssandimportedAssetsusingviteMetadataas suggested here.Although it's more verbose, it makes it easier to avoid collisions with rollup or other bundlers like WMR.
Notes ✏️
Added a new
vite:build-metadataplugin to initialize this new structure, since the nesting would require both the css and asset plugins (as well as any extensions that are added in the future) to check whetherviteMetadatawas already set, which is inconvenient and error-prone.