Make regex matcher timeout configurable #638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Oct 6, 2022
alexbakker
force-pushed
the
optional-timeout
branch
2 times, most recently
from
05319db
to
275483e
Compare
|
Apologies, I lost track of this. I didn't think of this at the time, but this will have to be an optional interface to avoid breaking API compatibility. |
alexbakker
force-pushed
the
optional-timeout
branch
from
275483e
to
bb58e91
Compare
I use chroma to syntax highlight code snippets on my blog. While profiling my static blog generator, I noticed that a lot of time was being spent setting up the regex timeout watcher: https://alexbakker.me/u/g987wpgo1v.svg. I'm not exactly sure why it's spending so much time there, but disabling the timeout results in a 2x performance improvement in my testing.
alexbakker
force-pushed
the
optional-timeout
branch
from
bb58e91
to
ab29907
Compare
|
No worries. I've removed the interface change entirely for now. Perhaps it makes more sense to hold off an adding an optional interface until we see more lexers that could support setting a timeout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use chroma to syntax highlight code snippets on my blog. While profiling my
static blog generator, I noticed that a lot of time was being spent setting up
the regex timeout watcher: https://alexbakker.me/u/g987wpgo1v.svg.
I'm not exactly sure why it's spending so much time there, but disabling the
timeout results in a 2x performance improvement in my testing.