fix: inconsistent YAML multiline parsing (#475) #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the YAML block scalar (multiline string) syntax is used with only one line of text, the single line is not matched by the current regexp. It currently only works with at least two lines.
This fixes the regexp by adding a special case for a single line after the first indentation in the block.
This is a fix for issue #475.
I tested the regexp used in the lexer, it simply doesn't match the content of the block scalar if it contains only one line; I guess the rendering inconsistency came from that line then being matched as something else.
The regexp uses a backreference to check that following lines (after the first) all have at least as much indentation as the first line; but this doesn't work when there is only the first line. I basically just added a special case when there is only one line.