Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: json example #395

Merged
merged 2 commits into from Apr 15, 2024
Merged

feat: json example #395

merged 2 commits into from Apr 15, 2024

Conversation

zhuliquan
Copy link
Contributor

json parser example

alecthomas
alecthomas approved these changes Apr 15, 2024
View reviewed changes
Copy link
Owner

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks

_examples/json/main.go Outdated
{Name: "True", Pattern: "true"},
{Name: "False", Pattern: "false"},
{Name: "EOL", Pattern: `[\n\r]+`},
{Name: "Whitespace", Pattern: `[ \t\n\r]+`},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\n\r will never match here because EOL takes precedence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it

_examples/json/main.go Show resolved Hide resolved
@alecthomas alecthomas merged commit b1ee217 into alecthomas:master Apr 15, 2024
2 checks passed
@zhuliquan zhuliquan deleted the feature-json_example branch April 15, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhuliquan @alecthomas