Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify struct ctor syntax and support struct deconstruction #1108

Merged
merged 14 commits into from May 2, 2024

Conversation

Lbqds
Copy link
Member

@Lbqds Lbqds commented May 1, 2024

No description provided.

Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.48%. Comparing base (5948060) to head (eddfcc2).

Files Patch % Lines
...h/src/main/scala/org/alephium/ralph/Operator.scala 93.33% 4 Missing ⚠️
...h/src/main/scala/org/alephium/ralph/Compiler.scala 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   92.41%   92.48%   +0.06%     
==========================================
  Files         378      379       +1     
  Lines       18764    18830      +66     
  Branches     2007     2046      +39     
==========================================
+ Hits        17341    17415      +74     
+ Misses       1423     1415       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lbqds
Copy link
Member Author

Lbqds commented May 1, 2024

@polarker It seems there are some issues with the github macos runner, causing other tests to fail as well: actions/setup-java#627, we may need to disable macos or manually install sbt.

@polarker
Copy link
Member

polarker commented May 2, 2024

@polarker It seems there are some issues with the github macos runner, causing other tests to fail as well: actions/setup-java#627, we may need to disable macos or manually install sbt.

Let's disable it temporarily!

Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.4% Duplication on New Code

See analysis details on SonarCloud

@polarker polarker merged commit 718af84 into master May 2, 2024
9 checks passed
@polarker polarker deleted the simplify-struct-ctor-syntax branch May 2, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants