Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kube-score to available tools #1066

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented May 11, 2024

Description

Add kube-score (and associated tests) to available tools

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)
    Fixes Add kube-score #1001

How Has This Been Tested?

functional on darwin x86_64

➜  arkade git:(kubescore) ✗ make build
go build
➜  arkade git:(kubescore) ✗ ./arkade get kube-score
Downloading: kube-score
2024/05/11 11:11:02 Looking up version for kube-score
2024/05/11 11:11:02 Found: v1.18.0
Downloading: https://github.com/zegl/kube-score/releases/download/v1.18.0/kube-score_1.18.0_darwin_amd64.tar.gz
6.32 MiB / 6.32 MiB [----------------------------------------------------------------------------------------------------] 100.00%
/var/folders/3w/tv6429v51kl_61rd1fr25sgm0000gq/T/arkade-2159499095/kube-score_1.18.0_darwin_amd64.tar.gz written.
2024/05/11 11:11:04 Extracted: /var/folders/3w/tv6429v51kl_61rd1fr25sgm0000gq/T/arkade-2159499095/kube-score
2024/05/11 11:11:04 Copying /var/folders/3w/tv6429v51kl_61rd1fr25sgm0000gq/T/arkade-2159499095/kube-score to /Users/rgee0/.arkade/bin/kube-score

Wrote: /Users/rgee0/.arkade/bin/kube-score (21.23MB)

make e2e

➜  arkade git:(kubescore) ✗ make e2e
...
PASS
coverage: 61.2% of statements
ok      github.com/alexellis/arkade/pkg/get     16.697s coverage: 61.2% of statements

test-tool kube-score

➜  arkade git:(kubescore) go build && ./hack/test-tool.sh kube-score       
+ ./arkade get kube-score --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/kube-score
/Users/rgee0/.arkade/bin/kube-score: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/kube-score
+ echo

+ ./arkade get kube-score --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/kube-score
/Users/rgee0/.arkade/bin/kube-score: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/kube-score
+ echo

+ ./arkade get kube-score --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/kube-score
/Users/rgee0/.arkade/bin/kube-score: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=xApvPOQccxisMNbrnSWr/eEsLrRU9XzVzynRVFKgC/lrlngbAWIEHvG7IA69Lu/78f5xYHyUu3tgUMIz7Iz, stripped
+ rm /Users/rgee0/.arkade/bin/kube-score
+ echo

+ ./arkade get kube-score --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/kube-score
/Users/rgee0/.arkade/bin/kube-score: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=oDVksJmeFMw-SNSFQGVY/LDwNKiUFK-M6ry01YbsE/dw7jnsJE2GjtZRHJJqx1/fjAdHSAFhUpkgJG27T47, stripped
+ rm /Users/rgee0/.arkade/bin/kube-score
+ echo

+ ./arkade get kube-score --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/kube-score.exe
/Users/rgee0/.arkade/bin/kube-score.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/kube-score.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

Signed-off-by: Richard Gee <richard@technologee.co.uk>
@alexellis alexellis merged commit 43a085f into alexellis:master May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kube-score
2 participants