Skip to content

Commit

Permalink
Update to clap 4 (#52)
Browse files Browse the repository at this point in the history
* Update to clap 4

* Test completions in release mode

* Remove clap already-default features

* cargo update

* Update print-completions --release note

* Move print-completions ci to separate flow
  • Loading branch information
alexheretic committed Oct 20, 2022
1 parent 2351ac0 commit 717f39d
Show file tree
Hide file tree
Showing 13 changed files with 133 additions and 111 deletions.
17 changes: 13 additions & 4 deletions .github/workflows/ci.yml
Expand Up @@ -15,10 +15,19 @@ jobs:
- run: rustup update stable
- uses: actions/checkout@v2
- run: cargo test --locked
# check print-completions don't fail
- run: cargo run -- print-completions bash
- run: cargo run -- print-completions fish
- run: cargo run -- print-completions zsh

# check print-completions don't fail
print-completions:
runs-on: ubuntu-latest
env:
RUST_BACKTRACE: 1
steps:
- run: rustup update stable
- uses: actions/checkout@v2
# Note: Using --release as clap debug-asserts panic
- run: cargo run --release --locked -- print-completions bash
- run: cargo run --release --locked -- print-completions fish
- run: cargo run --release --locked -- print-completions zsh

test-windows:
runs-on: windows-latest
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,6 @@
# Unreleased (v0.4.4)
* Update to clap v4 which changes help/about output & reduces binary size.

# v0.4.3
* Fix terminal breaking sometimes after exitting early.

Expand Down
141 changes: 77 additions & 64 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Expand Up @@ -11,8 +11,8 @@ readme = "README.md"

[dependencies]
anyhow = "1.0.53"
clap = { version = "3.2", features = ["derive", "env"] }
clap_complete = "3.2"
clap = { version = "4", features = ["derive", "env", "wrap_help"] }
clap_complete = "4"
console = "=0.15.1" # no lazy_static
ffprobe = "0.3"
futures = "0.3.19"
Expand Down

0 comments on commit 717f39d

Please sign in to comment.