Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show texts properly in SVG mode of AlexNet #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SuziKim
Copy link

@SuziKim SuziKim commented Sep 26, 2021

If there's a better way, please feel free to discuss!

@alexlenail
Copy link
Owner

Thanks for the PR? Could you describe the issue it addresses?

@SuziKim
Copy link
Author

SuziKim commented Oct 1, 2021

Sure, sure. Currently, only webGL mode allows text to be displayed for the AlexNet. It is a hotfix that displays the text of the tensor and conv dimensions in SVG mode.

@alexlenail
Copy link
Owner

Ah! That's quite useful!

When I test the PR on my machine, switching to SVG mode on the AlexNet vis still disables the "show dimensions" radio buttons. I think you can fix that here?

NN-SVG/AlexNet.html

Lines 354 to 359 in 7382c74

if (rendererType == 'svg') {
showDims = false;
$("#showDims").prop('disabled', true).prop('checked', false);
$("#showConvDims").prop('disabled', true).prop('checked', false);
$("#download").removeClass('disabled');
}

@SuziKim
Copy link
Author

SuziKim commented Oct 4, 2021

@alexlenail I updated your comment in 0978d1a. Thank you for your comment!

@alexlenail
Copy link
Owner

Hi @SuziKim

On your fork, I can't turn on dimension labels in SVG rendering:

image

Is that what you're seeing also?

@SuziKim
Copy link
Author

SuziKim commented Oct 5, 2021

May I ask about your environment? @alexlenail
For me, it works on Chrome and Safari on macOS Big Sur, as seen below:

Screen Shot 2021-10-05 at 7 39 03 PM

@gitsDhokla
Copy link

Can you make it such that it will make a visualisation for any PyTorch model? also in the conv layers, instead of making big cubes, can you segment it into grids, with multiple filters not connected into a cube but as different layers and also, a small number showing the output dimensions at a chosen layer, with the 2p-k/s equation? Would be really helpful, Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants