-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update uri to omit deployment ids for assistant and thread paths #431
Open
CarterBland
wants to merge
7
commits into
alexrudall:main
Choose a base branch
from
CarterBland:support-azure-openai-assistants
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: update uri to omit deployment ids for assistant and thread paths #431
CarterBland
wants to merge
7
commits into
alexrudall:main
from
CarterBland:support-azure-openai-assistants
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanmorrow
reviewed
Mar 14, 2024
Co-authored-by: Bryan Morrow <bryan@redcanary.com>
@alexrudall Any status on this? |
Thanks for patience, I need to get access to Azure OpenAI so I can test this & other Azure PRs - hope to within next week or 2 |
@alexrudall Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Solves Assistants Support for Azure's new API version 2024-02-15-preview #430
Tested in my own local application and the URI with the deployment id omitted unblocks the whole process from creating an assistant, thread, and message.
Solution:
Support assistants API by removing the deployment id for certain paths
Example:
https://custom-domain.openai.azure.com/openai/deployments/gpt-35-turbo/assistants
to
https://custom-domain.openai.azure.com/openai/assistants
All Submissions: