Patch 9 #1545
Closed
Patch 9 #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not the width that is important, it is the height. This way it works on a mobile screen no matter whether it is in portrait or landscape position, and also on other devices where window height is less than document height, even on a desktop computer when browser is not running fullscreen.
Fix the array_find call
Switch the duration with the appointment date time in the confirmatio…
Suppress session warnings
Add custom render method that can be easily overriden
Suppress warning errors and check the environment before using ldap f…
|
Hello! I appreciate you taking the time to translate those. However, while trying to keep translation files as thin as possible, I explicitly avoided to include such messages in them, because the UI will not normally allow you to trigger these cases. They can only be triggered, if the end user tries to tamper with the app. Therefore will skip this one
|
|
Hello.
I understand.
Now I won't bother translating all InvalidArgumentException messages 😊.
t: Timo
From: Alex Tselegidis ***@***.***>
Sent: Monday, May 27, 2024 5:52 PM
To: alextselegidis/easyappointments ***@***.***>
Cc: tm8544 ***@***.***>; Author ***@***.***>
Subject: Re: [alextselegidis/easyappointments] Patch 9 (PR #1545)
Hello!
I appreciate you taking the time to translate those.
However, while trying to keep translation files as thin as possible, I explicitly avoided to include such messages in them, because the UI will not normally allow you to trigger these cases.
They can only be triggered, if the end user tries to tamper with the app.
Therefore will skip this one
[https://camo.githubusercontent.com/81b6c5df2966c1d599a11bca89273dad26cab4714ea35c98678bb1c12ecf139e/68747470733a2f2f656173796170706f696e746d656e74732e6f72672f696d672f656173796170706f696e746d656e74732d7369676e61747572652e706e67]<https://camo.githubusercontent.com/81b6c5df2966c1d599a11bca89273dad26cab4714ea35c98678bb1c12ecf139e/68747470733a2f2f656173796170706f696e746d656e74732e6f72672f696d672f656173796170706f696e746d656e74732d7369676e61747572652e706e67>
Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!<https://easyappointments.org/get-a-free-quote>
—
Reply to this email directly, view it on GitHub<#1545 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADTXBP24QWYCNYXIHCD4AETZENCARAVCNFSM6AAAAABIAFKVPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTGYZTSNRUHA>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1541
This includes translations for RuntimeExceptions.