Fix overall_timeout_reading_json test failure #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Would it make sense to cut a patch release for this? I came across the issue because one of my crates depends on both ureq and serde_json and the package bump for ureq failed because the dependency constraint was impossible to resolve: msfjarvis/healthchecks-rs#41 |
|
Yep! Released 2.7.1. Thanks to you and @plugwash for running this down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602
serde_jsonintroduced a new API to properly support our use case of extracting the underlyingstd::io::ErrorKind, this PR updates the dependency to match the requisiteserde_jsonversion and switches to it.