Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recommend): remove unused trendingFacets props #1433

Merged
merged 3 commits into from Dec 16, 2022
Merged

fix(recommend): remove unused trendingFacets props #1433

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5700dea
fix: remove unused props for trending facets
marialungu Dec 15, 2022
8ed81ed
fix lint
marialungu Dec 15, 2022
e3e3692
revert changes to gitignore file
marialungu Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/recommend/src/types/TrendingFacetsQuery.ts
View file
Open in desktop
@@ -1,3 +1,6 @@
import { TrendingQuery } from './TrendingQuery';

export type TrendingFacetsQuery = Omit<TrendingQuery, 'model' | 'facetValue'>;
export type TrendingFacetsQuery = Omit<
TrendingQuery,
'model' | 'facetValue' | 'fallbackParameters' | 'queryParameters'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point why have a shared TrendingQuery type if they differ so much?

According to the API endpoints:

  • Trending facets
    • facetName: required
  • Trending items
    • facetName: optional
    • facetValue: optional

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's a good point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i wanted to do that in a separate PR, both for client and for the libs

>;