Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix algoliaserch/lite export from lite.esm.browser #1446

Closed
wants to merge 1 commit into from

Conversation

vishalmishra090
Copy link

@vishalmishra090 vishalmishra090 commented Mar 11, 2023

Fix #1445

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b405611:

Sandbox Source
javascript-client-app Configuration

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR

I'm not sure this is where the fix should be applied, it seems to be related to the exports in the package.json (see #1381)

a fix have been applied in v5 (the next major version, available on the next branch)

@vishalmishra090
Copy link
Author

Closing this PR with respect to #1381

@vishalmishra090 vishalmishra090 deleted the fix/1445 branch March 18, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

algoliasearch/lite must target algoliasearch-lite.esm.browser but currently it is target algoliasearch.cjs.js
2 participants