Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: openapi metadata files #1771

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

aallam
Copy link
Member

@aallam aallam commented Jul 17, 2023

🧭 What and Why

OpenAPI generators metadata files are pushed (and removed) from API clients repositories, although not useful for those repos.

Changes included:

Ignore OpenAPI generators metadata files.

@aallam aallam requested a review from a team as a code owner July 17, 2023 15:06
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit eec697b
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64b5591207519d000896399e
😎 Deploy Preview https://deploy-preview-1771--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 17, 2023

✔️ Code generated!

Name Link
🔨 Triggered by eec697bcb529424431d69ecbb26a1737f5a2628f
🔍 Generated code 71ae81c82124d7d7aa022f7160df6c5cad2411bf
🌲 Generated branch generated/chore/dart-openapi-metadata

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file .openapi-generator-ignore is useful for generation, but we can replace it by editing the generator directly.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I know why JS ignore all of that, is because the folder structure is so different from what's proposed by the default generator that we've removed every supported files, and therefore don't need it.


maybe it's just a git issue? I know some . files are not always tracked but not sure why it added/removed them

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this if there is no pushback

@Fluf22
Copy link
Contributor

Fluf22 commented Oct 23, 2023

There was, indeed, pushback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants