chore(ci): use docker #2525
Draft
chore(ci): use docker #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
millotp
force-pushed
the
chore/ci-docker
branch
from
65c56bb
to
d11b584
Compare
🔨 The codegen job will run at the end of the CI.Make sure your last commit does not contain generated code, it will be automatically pushed by our CI. |
|
this doesn't seem to be faster, I think we need to shrink the image size a lot |
If fine with it not being faster personally as long as it reduces the friction between local/CI it's still a huge improvement |
|
Wooo this is indeed a big improvment if it does not kills the CI duration ! |
millotp
force-pushed
the
chore/ci-docker
branch
from
5326587
to
d7f57dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Instead of initizalizing everything locally and on the CI, we can reuse the same docker image to save a lot of time.