feat(cts): generate tests for helpers #2798
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🔨 The codegen job will run at the end of the CI.Make sure your last commit does not contain generated code, it will be automatically pushed by our CI. |
millotp
force-pushed
the
feat/helper-tests
branch
2 times, most recently
from
8a51cc3
to
04b4cd7
Compare
millotp
commented
Feb 28, 2024
tests/CTS/client/search/helpers.json
Outdated
| "object": "$client", | ||
| "path": "generateSecuredApiKey", | ||
| "parameters": { | ||
| "parentAPIKey": "2640659426d5107b6e47d75db9cbaef8", |
There was a problem hiding this comment.
no worries this is our search api key, this means the generated key is usable for e2e
|
I was about to start adding those tests for PHP by hand, is it still useful or should I wait for this PR to be merged ? |
millotp
force-pushed
the
feat/helper-tests
branch
from
4ce6e93
to
59e4763
Compare
millotp
force-pushed
the
feat/helper-tests
branch
from
0ed2041
to
6f93939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Use the helper spec to generate tests, starting with the simplest: generateSecuredApiKey