Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body scroll should be restored when detached mode is responsively removed #1250

Closed
aldenquimby opened this issue May 10, 2024 · 4 comments · Fixed by #1251
Closed

Body scroll should be restored when detached mode is responsively removed #1250

aldenquimby opened this issue May 10, 2024 · 4 comments · Fixed by #1251

Comments

@aldenquimby
Copy link
Contributor

aldenquimby commented May 10, 2024 •
edited

Description

Body scroll should be restored when detached mode is responsively removed

Reproduction

Preview → - default sandbox has the bug

Steps

  1. Go to default sandbox
  2. Set a wide viewport so you do not have detached mode to start
  3. Open search panel and notice scrolling the page works
  4. With search panel open, decrease your viewport so detached mode is turned on
  5. With search panel still open, increase your viewport so detached mode is turn off
  6. Notice scrolling the page is now broken

algolia

Expected behavior

  • scrolling the page should work when detached mode is off

Environment

  • OS: [e.g. Windows / Linux / macOS / iOS / Android]: macOS
  • Browser: [e.g. Chrome, Safari]: Chrome latest
  • Autocomplete version: [e.g. 1.0.0]: 1.17.0
aldenquimby added a commit to aldenquimby/autocomplete that referenced this issue May 10, 2024
@aldenquimby
fix(js): allow body scroll when detached mode responsively disabled. f…
dd64a17 
…ixes algolia#1250
@aldenquimby aldenquimby mentioned this issue May 10, 2024
Merged
aldenquimby added a commit to aldenquimby/autocomplete that referenced this issue May 10, 2024
@aldenquimby
fix(js): allow body scroll when detached mode responsively disabled. f…
b73fddb 
…ixes algolia#1250
aldenquimby added a commit to aldenquimby/autocomplete that referenced this issue May 10, 2024
@aldenquimby
fix(js): allow body scroll when detached mode responsively disabled. f…
c4ed14d 
…ixes algolia#1250
@career-tokens
Copy link

I am interested in taking this up. I checked the sandbox and opened the app in a new tab. For large screen, you can scroll the entire page but for mobile view or smaller screen, somehow the scroll event is not getting activated.

@career-tokens
Copy link

One solution I can think of can't we keep the cancel button even in big screen? Like in my opinion, its still pretty frustating that I can't close the search menu after opening it. I guess we can keep a backdrop in the background when opening the search bar so as to let the user know they can't make change in the background before making their search.

@aldenquimby
Copy link
Contributor Author

@career-tokens I have a fixed posted on #1251

My team is using a forked version based on that fix in production, and all is well. Waiting on code review + tests and hopefully it will merge soon

@career-tokens
Copy link

Thanks for letting me know. I don't know whether I should ask it here but can you let me know whether you have NextJS based repositories with good first issues?

Haroenv added a commit that referenced this issue May 14, 2024
@aldenquimby @Haroenv
fix(js): allow body scroll when detached mode responsively disabled (#…
710f86b 
…1251)

* fix(js): allow body scroll when detached mode responsively disabled. fixes #1250

* refactor(js): add unit test

* move test

---------

Co-authored-by: Haroen Viaene <hello@haroen.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(js): allow body scroll when detached mode responsively disabled aldenquimby/autocomplete
2 participants
@aldenquimby @career-tokens