fix(js): allow body scroll when detached mode responsively disabled

[aldenquimby]

Summary

• Fixes Body scroll should be restored when detached mode is responsively removed #1250

Result

• See codesandbox example playground
• I can now scroll the body in my local app after transitioning in/out of detached mode:
  

Tech Notes

• I also tried this, but it did not work, and I'm not exactly sure why:

    return () => {
      if (panelContainerElement.contains(panelElement)) {
        if (isDetached.value) {
          setIsModalOpen(false);
        } else {
          panelContainerElement.removeChild(panelElement);
        }
      }
    };

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b73fddb:

Sandbox	Source
@algolia/autocomplete-example-github-repositories-custom-plugin	Configuration
@algolia/autocomplete-example-instantsearch	Configuration
@algolia/autocomplete-example-playground	Configuration
@algolia/autocomplete-example-preview-panel-in-modal	Configuration
@algolia/autocomplete-example-react-renderer	Configuration
@algolia/autocomplete-example-starter-algolia	Configuration
@algolia/autocomplete-example-starter	Configuration
@algolia/autocomplete-example-reshape	Configuration
@algolia/autocomplete-example-vue	Configuration
@algolia/autocomplete-example-playground	Issue #1250

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b11332:

Sandbox	Source
@algolia/autocomplete-example-github-repositories-custom-plugin	Configuration
@algolia/autocomplete-example-instantsearch	Configuration
@algolia/autocomplete-example-playground	Configuration
@algolia/autocomplete-example-preview-panel-in-modal	Configuration
@algolia/autocomplete-example-react-renderer	Configuration
@algolia/autocomplete-example-starter-algolia	Configuration
@algolia/autocomplete-example-starter	Configuration
@algolia/autocomplete-example-reshape	Configuration
@algolia/autocomplete-example-vue	Configuration
@algolia/autocomplete-example-playground	Issue #1250

[Haroenv]

Thanks a lot for this! Have you tried adding a test for this behaviour? Otherwise this should be good to merge

[aldenquimby]

@Haroenv I just added a test that I think should work (stitched together by copying various other tests), but I am unable to get the test suite working locally. Could you either check it for me locally, or enable the CI suite to run and I can debug based on those logs? Thank you!

[Haroenv]

thanks!

test doesn't pass yet, will fix

[Haroenv]

Thanks a lot for your contribution! This is now in 1.17.1 :)

[aldenquimby]

@Haroenv awesome, thank you for the assist!