Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module): correct ESM for Node usage #1214

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from
Draft

fix(module): correct ESM for Node usage #1214

wants to merge 3 commits into from

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Oct 25, 2023

Summary

resolve extensions and implement package.json#exports

Result

importing should now work as real ESM!

progress:

  • extensions added
  • initial exports key added (not sure if it's correct, CI implies it isn't, astro example implies it is)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3971830:

Sandbox Source
@algolia/autocomplete-example-github-repositories-custom-plugin Configuration
@algolia/autocomplete-example-instantsearch Configuration
@algolia/autocomplete-example-playground Configuration
@algolia/autocomplete-example-preview-panel-in-modal Configuration
@algolia/autocomplete-example-react-renderer Configuration
@algolia/autocomplete-example-starter-algolia Configuration
@algolia/autocomplete-example-starter Configuration
@algolia/autocomplete-example-reshape Configuration
@algolia/autocomplete-example-vue Configuration

Haroenv added a commit to Haroenv/astro-algolia-autocomplete that referenced this pull request Oct 25, 2023
@garethweaver
Copy link

Are we able to get this moved forwards?

@Haroenv
Copy link
Contributor Author

Haroenv commented Dec 4, 2023

Have you confirmed this works for you? You can continue temporary patch this or use patch-package if so, or you can investigate as well and see if a more minimal version does pass our build tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants