New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Vue IS geosearch demo to use the latest version #370
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
"vue-instantsearch": "3.8.1" | ||
"vue-instantsearch": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shouldn't use latest, but update manually to the latest version. This way it won't break when we release a major version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change in the package.json needs to be reflected in yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, good to know.
As breaking changes are expected to happen only on major version change, would it be relevant to use ^4.0.0 here, so both upgrade patch and minor version updates will be pulled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done the change, is that good for you now?
* Updated VueIS geosearch demo README * Update Vue InstantSearch/geo-search/README.md Co-authored-by: Haroen Viaene <hello@haroen.me> * Update Vue InstantSearch/geo-search/README.md Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Haroen Viaene <hello@haroen.me>
…samples into fix-vue-geosearch-demo # Conflicts: # Vue InstantSearch/geo-search/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either change to 3.9.0 or 4.3.3
@@ -12,7 +12,7 @@ | |||
"instantsearch.css": "7.3.1", | |||
"vue": "2.6.10", | |||
"vue-googlemaps": "0.1.2", | |||
"vue-instantsearch": "3.8.1" | |||
"vue-instantsearch": "^3.8.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"vue-instantsearch": "^3.8.1" | |
"vue-instantsearch": "^4.3.3" |
3.8.1 isn't the latest :) If updated across the major version, you need to check whether the imports still work (they normally should be the same, unless possibly /es replaced by /vue2/es)
Previously it was running on Vue InstantSearch v3.x, and the showing in the demo's title v2. Removed that reference and bumped to the latest VueIS version. Bonus: fixed the name of the package.