Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable Cmd+K shortcut when caps lock is on #1590

Merged
merged 3 commits into from Oct 23, 2022
Merged

feat: enable Cmd+K shortcut when caps lock is on #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a14691
fix: enable `Cmd+K` shortcut when caps lock is on
lex111 Oct 6, 2022
e319a18
Merge branch 'main' of github.com:algolia/docsearch into patch-2
lex111 Oct 23, 2022
cc8688b
Add tests
lex111 Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions cypress/integration/search/actions.spec.ts
View file
Open in desktop
Expand Up @@ -15,11 +15,21 @@ describe('Start', () => {
cy.modalIsVisibleAndFocused();
});

it('Open modal with key shortcut on Windows/Linux when caps lock is on', () => {
cy.get('body').type('{ctrl}K');
cy.modalIsVisibleAndFocused();
});

it('Open modal with key shortcut on macOS', () => {
cy.get('body').type('{meta}k');
cy.modalIsVisibleAndFocused();
});

it('Open modal with key shortcut on macOS when caps lock is on', () => {
cy.get('body').type('{meta}K');
cy.modalIsVisibleAndFocused();
});

it('Open modal with forward slash key shortcut', () => {
cy.get('body').type('/');
cy.modalIsVisibleAndFocused();
Expand Down
2 changes: 1 addition & 1 deletion packages/docsearch-react/src/useDocSearchKeyboardEvents.ts
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ export function useDocSearchKeyboardEvents({
if (
(event.keyCode === 27 && isOpen) ||
// The `Cmd+K` shortcut both opens and closes the modal.
(event.key === 'k' && (event.metaKey || event.ctrlKey)) ||
(event.key.toLowerCase() === 'k' && (event.metaKey || event.ctrlKey)) ||
// The `/` shortcut opens but doesn't close the modal because it's
// a character.
(!isEditingContent(event) && event.key === '/' && !isOpen)
Expand Down