fix(config): don't accept non-arrays for attributesToDisplay

This makes it consistent with `attributesForFaceting`. See #6023 for more info, although it doesn't change that use case.
algolia · Jan 31, 2024 · 307f26d · 307f26d
1 parent c841133
commit 307f26d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/packages/create-instantsearch-app/src/cli/__tests__/postProcessAnswers.js b/packages/create-instantsearch-app/src/cli/__tests__/postProcessAnswers.js
@@ -281,3 +281,23 @@ test('removes `imageAttribute` from `attributesToDisplay`', async () => {
     })
   );
 });
+
+test('ignores invalid input', async () => {
+  expect(
+    await postProcessAnswers({
+      configuration: {},
+      templateConfig: {},
+      optionsFromArguments: {},
+      answers: {
+        attributesToDisplay: 'test',
+        attributesForFaceting: 'test',
+      },
+    })
+  ).toEqual(
+    expect.objectContaining({
+      attributesForFaceting: false,
+      attributesToDisplay: false,
+      flags: { autocomplete: false, dynamicWidgets: false, insights: false },
+    })
+  );
+});
diff --git a/packages/create-instantsearch-app/src/cli/postProcessAnswers.js b/packages/create-instantsearch-app/src/cli/postProcessAnswers.js
@@ -65,9 +65,11 @@ async function postProcessAnswers({
     template: templatePath,
     installation: optionsFromArguments.installation,
     currentYear: new Date().getFullYear(),
-    attributesToDisplay: combinedAnswers.attributesToDisplay?.filter(
-      (attribute) => attribute !== combinedAnswers.imageAttribute
-    ),
+    attributesToDisplay:
+      Array.isArray(combinedAnswers.attributesToDisplay) &&
+      combinedAnswers.attributesToDisplay.filter(
+        (attribute) => attribute !== combinedAnswers.imageAttribute
+      ),
     attributesForFaceting:
       Array.isArray(combinedAnswers.attributesForFaceting) &&
       combinedAnswers.attributesForFaceting.filter(