Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(searchbox): add aria-hidden to svg icons #5547

Merged
merged 9 commits into from Mar 16, 2023
Merged

fix(searchbox): add aria-hidden to svg icons #5547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9f68ae7
fix: add aria-hidden=true to all instances of ais-SearchBox-submitIcon
pat-sullivan Mar 13, 2023
7d4cf55
fix: add aria-hidden=true to all instances of ais-SearchBox-loadingIcon
pat-sullivan Mar 14, 2023
d857791
fix: add aria-hidden=true to all instances of ais-SearchBox-resetIcon
pat-sullivan Mar 14, 2023
488be93
fix: add remaining svg aria-hidden labels to components and IS search…
pat-sullivan Mar 15, 2023
1922cab
Merge branch 'master' into fix/add-aria-hidden-to-svg-icons
pat-sullivan Mar 15, 2023
df3ef32
chore: move aria-hidden attrs to top for a-z order
pat-sullivan Mar 15, 2023
ee66350
feat(current-refinements): provide indexId of refinements in transfor…
dhayab Mar 15, 2023
e232527
Merge branch 'fix/add-aria-hidden-to-svg-icons' of github.com:algolia…
pat-sullivan Mar 15, 2023
ee46988
chore: more aria-hidden attrs to top for a-z order
pat-sullivan Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/react-hooks/e-commerce/App.tsx
View file
Open in desktop
Expand Up @@ -249,6 +249,7 @@ function SubmitIcon() {
width="16"
height="16"
viewBox="0 0 18 18"
aria-hidden="true"
>
<g
fill="none"
Expand Down
2 changes: 2 additions & 0 deletions examples/react/geo-search/src/__tests__/__snapshots__/App.test.js.snap
View file
Open in desktop
Expand Up @@ -34,6 +34,7 @@ Array [
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -52,6 +53,7 @@ Array [
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
2 changes: 2 additions & 0 deletions examples/react/multi-index/src/__tests__/__snapshots__/App.test.js.snap
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@ Array [
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -51,6 +52,7 @@ Array [
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
2 changes: 2 additions & 0 deletions examples/react/next/tests/__snapshots__/index.test.js.snap
View file
Open in desktop
Expand Up @@ -37,6 +37,7 @@ exports[`Next app recipes App renders without crashing 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -55,6 +56,7 @@ exports[`Next app recipes App renders without crashing 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
2 changes: 2 additions & 0 deletions examples/react/react-router-v3/src/__tests__/__snapshots__/App.test.js.snap
View file
Open in desktop
Expand Up @@ -44,6 +44,7 @@ exports[`react-router recipe App renders without crashing 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -62,6 +63,7 @@ exports[`react-router recipe App renders without crashing 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
2 changes: 2 additions & 0 deletions examples/react/react-router/src/__tests__/__snapshots__/App.test.js.snap
View file
Open in desktop
Expand Up @@ -44,6 +44,7 @@ exports[`react-router recipe App renders without crashing 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -62,6 +63,7 @@ exports[`react-router recipe App renders without crashing 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
2 changes: 2 additions & 0 deletions examples/react/server-side-rendering/src/__snapshots__/App.test.js.snap
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@ Array [
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -51,6 +52,7 @@ Array [
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
6 changes: 6 additions & 0 deletions packages/instantsearch.js/src/widgets/refinement-list/__tests__/refinement-list.test.tsx
View file
Open in desktop
Expand Up @@ -91,6 +91,7 @@ describe('refinementList', () => {
type="submit"
>
<svg
aria-hidden="true"
class="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -108,6 +109,7 @@ describe('refinementList', () => {
type="reset"
>
<svg
aria-hidden="true"
class="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand All @@ -123,6 +125,7 @@ describe('refinementList', () => {
hidden=""
>
<svg
aria-hidden="true"
class="ais-SearchBox-loadingIcon"
height="16"
stroke="#444"
Expand Down Expand Up @@ -273,6 +276,7 @@ describe('refinementList', () => {
type="submit"
>
<svg
aria-hidden="true"
class="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -289,6 +293,7 @@ describe('refinementList', () => {
type="reset"
>
<svg
aria-hidden="true"
class="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand All @@ -304,6 +309,7 @@ describe('refinementList', () => {
hidden=""
>
<svg
aria-hidden="true"
class="ais-SearchBox-loadingIcon"
height="16"
stroke="#444"
Expand Down
3 changes: 3 additions & 0 deletions packages/instantsearch.js/src/widgets/search-box/__tests__/search-box.test.tsx
View file
Open in desktop
Expand Up @@ -61,6 +61,7 @@ describe('searchBox', () => {
type="submit"
>
<svg
aria-hidden="true"
class="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -78,6 +79,7 @@ describe('searchBox', () => {
type="reset"
>
<svg
aria-hidden="true"
class="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand All @@ -93,6 +95,7 @@ describe('searchBox', () => {
hidden=""
>
<svg
aria-hidden="true"
class="ais-SearchBox-loadingIcon"
height="16"
stroke="#444"
Expand Down
3 changes: 3 additions & 0 deletions packages/instantsearch.js/src/widgets/search-box/defaultTemplates.tsx
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ const defaultTemplate: SearchBoxComponentTemplates = {
viewBox="0 0 20 20"
width="10"
height="10"
aria-hidden="true"
>
<path d="M8.114 10L.944 2.83 0 1.885 1.886 0l.943.943L10 8.113l7.17-7.17.944-.943L20 1.886l-.943.943-7.17 7.17 7.17 7.17.943.944L18.114 20l-.943-.943-7.17-7.17-7.17 7.17-.944.943L0 18.114l.943-.943L8.113 10z" />
</svg>
Expand All @@ -23,6 +24,7 @@ const defaultTemplate: SearchBoxComponentTemplates = {
width="10"
height="10"
viewBox="0 0 40 40"
aria-hidden="true"
>
<path d="M26.804 29.01c-2.832 2.34-6.465 3.746-10.426 3.746C7.333 32.756 0 25.424 0 16.378 0 7.333 7.333 0 16.378 0c9.046 0 16.378 7.333 16.378 16.378 0 3.96-1.406 7.594-3.746 10.426l10.534 10.534c.607.607.61 1.59-.004 2.202-.61.61-1.597.61-2.202.004L26.804 29.01zm-10.426.627c7.323 0 13.26-5.936 13.26-13.26 0-7.32-5.937-13.257-13.26-13.257C9.056 3.12 3.12 9.056 3.12 16.378c0 7.323 5.936 13.26 13.258 13.26z" />
</svg>
Expand All @@ -36,6 +38,7 @@ const defaultTemplate: SearchBoxComponentTemplates = {
height="16"
viewBox="0 0 38 38"
stroke="#444"
aria-hidden="true"
>
<g fill="none" fillRule="evenodd">
<g transform="translate(1 1)" strokeWidth="2">
Expand Down
3 changes: 3 additions & 0 deletions packages/react-instantsearch-dom/src/components/SearchBox.js
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ const defaultLoadingIndicator = (
xmlns="http://www.w3.org/2000/svg"
stroke="#444"
className={cx('loadingIcon')}
aria-hidden="true"
>
<g fill="none" fillRule="evenodd">
<g transform="translate(1 1)" strokeWidth="2">
Expand All @@ -40,6 +41,7 @@ const defaultReset = (
viewBox="0 0 20 20"
width="10"
height="10"
aria-hidden="true"
>
<path d="M8.114 10L.944 2.83 0 1.885 1.886 0l.943.943L10 8.113l7.17-7.17.944-.943L20 1.886l-.943.943-7.17 7.17 7.17 7.17.943.944L18.114 20l-.943-.943-7.17-7.17-7.17 7.17-.944.943L0 18.114l.943-.943L8.113 10z" />
</svg>
Expand All @@ -52,6 +54,7 @@ const defaultSubmit = (
width="10"
height="10"
viewBox="0 0 40 40"
aria-hidden="true"
>
<path d="M26.804 29.01c-2.832 2.34-6.465 3.746-10.426 3.746C7.333 32.756 0 25.424 0 16.378 0 7.333 7.333 0 16.378 0c9.046 0 16.378 7.333 16.378 16.378 0 3.96-1.406 7.594-3.746 10.426l10.534 10.534c.607.607.61 1.59-.004 2.202-.61.61-1.597.61-2.202.004L26.804 29.01zm-10.426.627c7.323 0 13.26-5.936 13.26-13.26 0-7.32-5.937-13.257-13.26-13.257C9.056 3.12 3.12 9.056 3.12 16.378c0 7.323 5.936 13.26 13.258 13.26z" />
</svg>
Expand Down
6 changes: 6 additions & 0 deletions packages/react-instantsearch-dom/src/components/__tests__/__snapshots__/Menu.js.snap
View file
Open in desktop
Expand Up @@ -38,6 +38,7 @@ exports[`Menu Menu with search inside items but no search results 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -56,6 +57,7 @@ exports[`Menu Menu with search inside items but no search results 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down Expand Up @@ -178,6 +180,7 @@ exports[`Menu Menu with search inside items with search results 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -196,6 +199,7 @@ exports[`Menu Menu with search inside items with search results 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down Expand Up @@ -274,6 +278,7 @@ exports[`Menu applies translations 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -292,6 +297,7 @@ exports[`Menu applies translations 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down
6 changes: 6 additions & 0 deletions ...ges/react-instantsearch-dom/src/components/__tests__/__snapshots__/RefinementList.js.snap
View file
Open in desktop
Expand Up @@ -38,6 +38,7 @@ exports[`RefinementList applies translations 1`] = `
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -56,6 +57,7 @@ exports[`RefinementList applies translations 1`] = `
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down Expand Up @@ -394,6 +396,7 @@ exports[`RefinementList refinement list with search inside items but no search r
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -412,6 +415,7 @@ exports[`RefinementList refinement list with search inside items but no search r
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down Expand Up @@ -546,6 +550,7 @@ exports[`RefinementList refinement list with search inside items with search res
type="submit"
>
<svg
aria-hidden="true"
className="ais-SearchBox-submitIcon"
height="10"
viewBox="0 0 40 40"
Expand All @@ -564,6 +569,7 @@ exports[`RefinementList refinement list with search inside items with search res
type="reset"
>
<svg
aria-hidden="true"
className="ais-SearchBox-resetIcon"
height="10"
viewBox="0 0 20 20"
Expand Down